[
https://issues.apache.org/jira/browse/LOG4J2-2668?focusedWorklogId=328413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328413
]
ASF GitHub Bot logged work on LOG4J2-2668:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/19 08:53
Start Date: 15/Oct/19 08:53
Worklog Time Spent: 10m
Work Description: Guidoooch commented on pull request #3: add support for
scala 2.13.0 [LOG4J2-2668]
URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r334825127
##########
File path:
src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package org.apache.logging.log4j.scala
+
+import org.apache.logging.log4j.ThreadContext
+
+import scala.jdk.CollectionConverters._
+import scala.collection.{immutable, mutable}
+
+/** Manages the context data (context map, MDC) that is added to log events.
+ *
+ * A wrapper around `org.apache.logging.log4j.ThreadContext`.
+ */
+object LoggingContext extends mutable.Map[String, String] {
Review comment:
This looks very good, I did similar changes locally and works well.
I have just a couple of comments:
- Could update to use scala 2.13.1
- Could update to sbt 1.3.2
- Could update to scalatest 3.0.8
- Could update to mockito 3.1.0
I'd be happy to bring in those changes when this pull request is merged
though!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 328413)
Time Spent: 1.5h (was: 1h 20m)
> Add support for Scala 2.13
> --------------------------
>
> Key: LOG4J2-2668
> URL: https://issues.apache.org/jira/browse/LOG4J2-2668
> Project: Log4j 2
> Issue Type: New Feature
> Components: Scala API
> Affects Versions: 11.0
> Reporter: Matt Sicker
> Assignee: Matt Sicker
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> There's already an early access module for 2.13 from back when it was in
> development. Now that 2.13 is released, we can make our own release.
> PR available: https://github.com/apache/logging-log4j-scala/pull/2
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
