[
https://issues.apache.org/jira/browse/LOG4J2-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976698#comment-16976698
]
Rémi C. edited comment on LOG4J2-2721 at 11/18/19 4:53 PM:
-----------------------------------------------------------
I will just had that all the other function except .with(String, Object) takes
a primitive type as a value so no concerns for null because :
{code:java}
/* code ran on : https://www.tutorialspoint.com/compile_java_online.php */
public class HelloWorld{public class HelloWorld{
public static void main(String []args){
System.out.println(Long.toString(getLong()));
}
public long getLong() {
return null;
}
}
This returns
HelloWorld.java:8: error: incompatible types: <null> cannot be converted to long
return null;
^{code}
No concerns because method will never return a null value as it is not handle
by long (but Long type yes).
But String is not a primitive type. It is the one that can take null.
Plus at the time they made the String Class, they considered that the null
value for a String is evaluated "null" by the methods valueOf.
was (Author: micromic):
I will just had that all the other function except .with(String, Object) takes
a primitive type as a value so no concerns for null because :
{code:java}
/* code ran on : https://www.tutorialspoint.com/compile_java_online.php */
public class HelloWorld{public class HelloWorld{
public static void main(String []args){
System.out.println(Long.toString(getLong()));
}
public long getLong() {
return null;
}
}
This returns
HelloWorld.java:8: error: incompatible types: <null> cannot be converted to long
return null;
^{code}
No concerns because method will never take a null it is not handle by long.
But String is not a primitive type. It is the one that can take null.
Plus at the time they made the String Class, they considered that the null
value for a String is evaluated "null" by the methods valueOf.
> Thread crash when parameter is a null value for StringMapMessage
> ----------------------------------------------------------------
>
> Key: LOG4J2-2721
> URL: https://issues.apache.org/jira/browse/LOG4J2-2721
> Project: Log4j 2
> Issue Type: Bug
> Components: API
> Affects Versions: 2.12.1
> Reporter: Rémi C.
> Priority: Major
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> {code:java}
> logger.info(myMarker, new StringMapMessage()
> .with("message", "Test message")
> .with("event.action", null)
> .with("event.category", "General"));{code}
> This will crash. It is not supposed to happen, but sometimes a parameter can
> be null unexpectedly.
>
> MapMessage should be "null safe".
>
> [https://github.com/apache/logging-log4j2/blob/master/log4j-api/src/main/java/org/apache/logging/log4j/message/MapMessage.java]
> line 732
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
