ChristophKaser commented on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-574099415 I only count three: - The one I replaced - [Two](https://github.com/apache/logging-log4j2/blob/231f669df3f16c03e35e92460787f73f265ee3ca/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager.java#L158) [checks](https://github.com/apache/logging-log4j2/blob/231f669df3f16c03e35e92460787f73f265ee3ca/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java#L94) that the fileName is null when DirectWriteRolloverStrategy is used. I am unsure about those checks - in theory it may be possible to build a RolloverStrategy that implements DirectFileRolloverStrategy but also uses the fileName. But I don't think the interface is meant to be used that way, so I guess it would make sense to replace those as well. What do you think? I added a simple regression test to this patch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
