stephen-webb commented on a change in pull request #14: Replace ant build with 
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373738203
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
 
 Review comment:
   I think I may have used some cmake that requires 3.13. It was 6 months ago 
so I cannot recall exact details.
   
   I have been trying to follow best practices in Professional CMake (4th 
Edition)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to