trejkaz commented on issue #349: Fix erroneous usage of default locale
URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599873519
 
 
   Alright, so as it turns out, all current locales show no failure with 
passing in the digits in Latin even if that locale in question uses different 
digits, which must be a hidden feature of NumberFormat's parser.
   
   Although:
   
   There is _definitely_ a way I can make this code break, it involves 
substituting the LocaleServiceProvider / NumberFormatProvider, which is how I 
discovered this issue in the first place, but that's a whole other topic which 
I promise to you will look a lot more contrived if I contributed that as the 
test case.
   
   So at this point it is far easier to just say: using the default locale in 
library code should be avoided - I'm removing one such usage of the code free 
of charge. :)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to