[ 
https://issues.apache.org/jira/browse/LOG4J2-2749?focusedWorklogId=438659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438659
 ]

ASF GitHub Bot logged work on LOG4J2-2749:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/May/20 10:49
            Start Date: 29/May/20 10:49
    Worklog Time Spent: 10m 
      Work Description: vy commented on pull request #362:
URL: https://github.com/apache/logging-log4j2/pull/362#issuecomment-635907456


   Thanks for the patch @gagoman! `release-2.x` builds are failing right now 
due to some other problem. Once they got fixed, I will merge the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 438659)
    Time Spent: 20m  (was: 10m)

> JsonLayout KeyValuePair should not log json key which has empty or blank value
> ------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2749
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2749
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Layouts
>    Affects Versions: 2.12.1
>            Reporter: Mahesh Gujale
>            Priority: Minor
>              Labels: features
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JsonLayout configured with following 
> {quote}<Console name="APP_STAT" target="SYSTEM_OUT">
>          <JSONLayout objectMessageAsJsonObject="true" compact="true" 
> eventEol="true">
>               <KeyValuePair key="timestamp" 
> value="$${date:yyyy-MM-dd'T'HH:mm:ss.SSSZ}" />
>                  <KeyValuePair key="type" value="$${ctx:type:-}" />
>          </JSONLayout>
> </Console>
> {quote}
> Which  logs as below
> {quote}{ 
>  "thread":"http-nio-8080-exec-1",
>  "level":"INFO",
>  "loggerName":"com.xyz.logging.interceptor.LogApiInterceptor",
>  "message":"App Stat",
>  "endOfBatch":true,
>  "loggerFqcn":"org.apache.logging.log4j.spi.AbstractLogger",
>  "instant":{ 
>    "epochSecond":1577422969,
>    "nanoOfSecond":22000000
>  },
>  "threadId":26,
>  "threadPriority":5,
>  "timestamp":"2019-12-27T10:32:49.022+0530",
>  "type":"",
> }
> {quote}
>  If we do not put 'type' in MDC or ThreadContext then json contains blank or 
> empty key 'type'. If the key type is not put MDC or if its value is empty 
> string/blank then JsonLayout should not log the key type in json.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to