garydgregory commented on pull request #366: URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-650743832
Yeah, I do not have a use case for that, I just wanted to mention it for completeness sake as well as guidance for contributing: don't break binary compatibility of the public API, also small PRs are better than larger ones. Gary On Sat, Jun 27, 2020, 20:11 Ralph Goers <[email protected]> wrote: > That is true, but it seems odd to add the StackTraceElement to things like > traceEntry & traceExit and then ALSO add them to Messages. The location > information isn't logically part of a Message. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/pull/366#issuecomment-650652949>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAJB6N25WAKKFSGK35IHB43RY2DCDANCNFSM4OKEQ7KA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
