carterkozak commented on pull request #390: URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-662432635
> I don't think it can be guaranteed that the methods will always be called on the same thread It can't be guaranteed that the original thread is still around or has the same name either, and it's expensive to look up even if it is (where the cost scales with total live threads). This becomes a question of risk tolerance and computational cost. I can keep the fallback around, I think the initial current-thread-check will handle most cases, I imagine most log4j1.2 shim users aren't using asynchronous components. It's probably a good idea to replace the Thread reference with `threadId` and `threadPriority` fields to avoid holding thread references if the event sits in a queue for a while. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
