pm-cfs opened a new pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43


   # Summary
   Previously we either ACCEPTed or DENYed any log when this filter was 
present. This configuration prevented proper filter chaining.
   
   # Changes
   * Update mapfilter to return NEUTRAL when additional filters should be 
considered.
   * Update tests to check for these values.
   
   # Testing
   Run the unit test.
   
   To manually test: using any logging configuration where IP addreses are 
available in MDC (implementation dependent):
   ```
      <filter class="MapFilter">
         <param name="ip" value="192.169.0.2" />
         <param name="AcceptOnMatch" value="false" />
       </filter>
       <filter class="MapFilter">
         <param name="ip" value="192.169.0.3" />
         <param name="AcceptOnMatch" value="false" />
       </filter>
   ```
   * In the first filter set the IP address to a machine/VM you want to ignore; 
entries from this machine won't be logged.
   * In the second, change ip address to another machine to ignore.
   * Now verify that the first and second are ignored and a third machine is 
accepted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to