ams-tschoening commented on a change in pull request #45:
URL: https://github.com/apache/logging-log4cxx/pull/45#discussion_r533962761
##########
File path: src/main/cpp/rollingfileappender.cpp
##########
@@ -340,11 +340,13 @@ bool RollingFileAppenderSkeleton::rollover(Pool& p)
}
else
{
+ closeWriter();
Review comment:
[activateOptions](https://github.com/apache/logging-log4cxx/blob/9cf215f9721aa6add98674bfc706452e62268b50/src/main/cpp/fileappender.cpp#L155)
calls
[setFile](https://github.com/apache/logging-log4cxx/blob/9cf215f9721aa6add98674bfc706452e62268b50/src/main/cpp/fileappender.cpp#L164)
as well which calls
[closeWriter](https://github.com/apache/logging-log4cxx/blob/9cf215f9721aa6add98674bfc706452e62268b50/src/main/cpp/fileappender.cpp#L281)
already. So the explicit call might not be necessary anymore.
Though, just a hint, not worth blocking the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
