ams-tschoening commented on a change in pull request #46:
URL: https://github.com/apache/logging-log4cxx/pull/46#discussion_r549115000
##########
File path: src/main/include/log4cxx/net/syslogappender.h
##########
@@ -136,6 +148,16 @@ class LOG4CXX_EXPORT SyslogAppender : public
AppenderSkeleton
return facilityPrinting;
}
+ inline void setMaxMessagelength(int maxMessageLength1)
Review comment:
* Lower case `l` seems wrong: `setMaxMessagelength` vs.
`setMaxMessageLength`, like `getMaxMessageLength`.
* `maxMessageLength1` to not accidently use the instance variable?
* How about a shorter property like `maxMsgLength` instead? I can easily
live with yours of course, sounds a bit noisy in my opinion, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
