carterkozak commented on pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-752246841
> The major improvement this change set brings is that there are no smart whitelist of failures that are subject to handling. The downside is when an error is raised, we pay the full cost of thread creation and context switching rather than catching and continuing. Can we compare this solution with a potential alternative: The `AppenderControl` is reverted to catch `Exception`, not `Throwable`/`Error`, however `AsyncAppender.AsyncThread.run()` is updated to catch `Throwable` in both `callAppenders` and the `errorAppender.callAppender` try/catch? I believe this would match how the disruptor-based `AsyncContextSelector` implementation works already. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
