vy commented on pull request #454: URL: https://github.com/apache/logging-log4j2/pull/454#issuecomment-755375215
> Yep, I think the changes are good, thanks! My commit was primarily an exercise to familiarize myself with the code :-) Thanks, will merge it! > One oddity the meta revolver surfaced was that the context contains data directly describing the root object (root attribute, additional properties) that may be better decomposed into the template model rather than the context. No changes requested, just something that might be worth considering. Very good insight! I indeed smelled the same while working on the issue. Just to make sure we are on the same page, what do you exactly mean by the *template model*? Do you mean converting, say, *event template additional fields* to a template resolver? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
