carterkozak edited a comment on pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-756187667
One point of clarification, I don't think the `Log4jLogEvent` change results in any different behavior, each event (with the exception of `SHUTDOWN_LOG_EVENT`) is transformed to a `Log4jLogEvent` in the `AsyncAppender.append` method here: https://github.com/apache/logging-log4j2/blob/d96869bc3b1225f1b080ce44e6a27c11f9d6828b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java#L162 I still need to review the shutdown mechanism for thread safety, although at a glance the queue empty checks that exist on release-2.x are entirely threadsafe either... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
