fluffynuts edited a comment on pull request #72: URL: https://github.com/apache/logging-log4net/pull/72#issuecomment-764895685
I'm not sold yet; right now, it adds complexity and risk: it's a way for third-party code to intercept logging when that third-party code takes a guess that an appender uses some built-in service-locator logic. I'm on the fence. I have to bear in mind that this is not some rinky-dink package like one of my personal ones: where some of mine have had about 300k downloads _for all time_, log4net has garnered just shy of 1/2 a million downloads _since the last release alone_. Changes here affect a lot of people and getting new changes (ie fixes) out takes time because of the processes involved with the Apache org. So far, I can't see this solving a necessary problem. It's not that there's something wrong with the code - quite the opposite - but rather that there's nothing that's specifically broke in log4net _per se_. Your requirements can be met through your own service-locator implementation; even if this was for publishing a third-party appender nuget library, that library could host the service-locator itself, limiting the scope of possible effect by nefarious actors. Perhaps we'll revisit this some day and I'll be plainly wrong and you'll be able to say "I told you so". I do realise that you've put in significant effort and I really hope that I'm not putting you off of future contributions, because I do value the contributions you've made in the past. I have to be more conservative with this project than I am with my own. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
