[
https://issues.apache.org/jira/browse/LOG4J2-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici updated LOG4J2-2973:
----------------------------------
Description:
In [a GitHub
discussion|https://github.com/apache/logging-log4j2/commit/61f125b8b879d1a0852b24358da7424baeb20c31#r44935541],
it has been shared that the injection of plug-in builder attributes of type
array from properties files is not working. But... It actually works! The
reason it doesn't work for injecting a field of type
{{EventTemplateAdditionalField[]}} is the {{EventTemplateAdditionalField#type}}
field whose name conflicts with the {{type}} keyword property file loader uses
to determine the type of an element.
This PR renames {{EventTemplateAdditionalField#type}} to {{format}}. While this
is *not* a backward compatible change, injection of JSON template layout
{{eventTemplateAdditionalFields}} has already been broken in release 2.14.0 and
the introduced fix has already broken the backward compatibility. See
LOG4J2-2961 for details. Hence, it should be okay. ;)
was:
In [a GitHub
discussion|https://github.com/apache/logging-log4j2/commit/61f125b8b879d1a0852b24358da7424baeb20c31#r44935541),
it has been shared that the injection of plug-in builder attributes of type
array from properties files is not working. But... It actually works! The
reason it doesn't work for injecting a field of type
{{EventTemplateAdditionalField[]}} is the {{EventTemplateAdditionalField#type}}
field whose name conflicts with the {{type}} keyword property file loader uses
to determine the type of an element.
This PR renames {{EventTemplateAdditionalField#type}} to {{format}}. While this
is *not* a backward compatible change, injection of JSON template layout
{{eventTemplateAdditionalFields}} has already been broken in release 2.14.0 and
the introduced fix has already broken the backward compatibility. See
LOG4J2-2961 for details. Hence, it should be okay. ;)
> Rename EventTemplateAdditionalField#type (conflicting with properties file
> parser) to "format"
> ----------------------------------------------------------------------------------------------
>
> Key: LOG4J2-2973
> URL: https://issues.apache.org/jira/browse/LOG4J2-2973
> Project: Log4j 2
> Issue Type: Bug
> Components: JsonTemplateLayout
> Affects Versions: 2.14.0
> Reporter: Volkan Yazici
> Assignee: Volkan Yazici
> Priority: Major
> Fix For: 3.0.0, 2.14.1
>
>
> In [a GitHub
> discussion|https://github.com/apache/logging-log4j2/commit/61f125b8b879d1a0852b24358da7424baeb20c31#r44935541],
> it has been shared that the injection of plug-in builder attributes of type
> array from properties files is not working. But... It actually works! The
> reason it doesn't work for injecting a field of type
> {{EventTemplateAdditionalField[]}} is the
> {{EventTemplateAdditionalField#type}} field whose name conflicts with the
> {{type}} keyword property file loader uses to determine the type of an
> element.
> This PR renames {{EventTemplateAdditionalField#type}} to {{format}}. While
> this is *not* a backward compatible change, injection of JSON template layout
> {{eventTemplateAdditionalFields}} has already been broken in release 2.14.0
> and the introduced fix has already broken the backward compatibility. See
> LOG4J2-2961 for details. Hence, it should be okay. ;)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
