vy commented on a change in pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#discussion_r577592796
##########
File path: log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
##########
@@ -80,59 +80,61 @@
* Logs an exception or error that has been caught to a specific logging
level.
*
* @param level The logging Level.
- * @param t The Throwable.
+ * @param throwable the Throwable.
*/
- void catching(Level level, Throwable t);
+ void catching(Level level, Throwable throwable);
/**
- * Logs an exception or error that has been caught. Normally, one may wish
to provide additional information with an
- * exception while logging it; in these cases, one would not use this
method. In other cases where simply logging
- * the fact that an exception was swallowed somewhere (e.g., at the top of
the stack trace in a {@code main()}
- * method), this method is ideal for it.
+ * Logs an exception or error that has been caught at the {@link
Level#ERROR ERROR} level.
Review comment:
Corrected.
##########
File path: log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
##########
@@ -292,12 +294,12 @@
/**
* Logs a message at the {@link Level#DEBUG DEBUG} level including the
stack trace of the {@link Throwable}
- * <code>t</code> passed as parameter.
+ * <code>throwable</code> passed as parameter.
*
* @param message the message to log.
- * @param t the exception to log, including its stack trace.
+ * @param throwable the exception to log, including its stack trace.
*/
Review comment:
Corrected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
