carterkozak commented on a change in pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468#discussion_r579657898
##########
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/CallerInformationTest.java
##########
@@ -57,9 +57,9 @@ public void testMethodLogger() throws Exception {
logger.warn("brains~~~");
logger.info("Itchy. Tasty.");
final List<String> messages = app.getMessages();
- assertEquals("Incorrect number of messages.", 5, messages.size());
+ assertThat(messages).describedAs("Incorrect number of
messages.").hasSize(5);
Review comment:
In the case the test fails fails, il the new code is able to give us
more data to understand what’s broken. The failure message includes the list
contents in addition to expected and actual lengths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
