ams-tschoening commented on a change in pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r585600144
##########
File path: src/main/cpp/domconfigurator.cpp
##########
@@ -331,10 +321,12 @@ void DOMConfigurator::parseErrorHandler(Pool& p,
AppenderMap& appenders)
{
- ErrorHandlerPtr eh = OptionConverter::instantiateByClassName(
+ ErrorHandlerPtr eh;
+ std::shared_ptr<Object> obj = OptionConverter::instantiateByClassName(
Review comment:
[Only at least C++11 will be
supported](https://lists.apache.org/thread.html/re744feb89b0bf9a15b03d145a88fe0d0be48ad069d12a31b8ba5d461%40%3Cdev.logging.apache.org%3E)
in future, so it doesn't make too much sense anymore to migrate those calls to
`log4cxx::`. Instead, the project is simply going to depend on [std::shared_ptr
without
BOOST-fallback](https://lists.apache.org/thread.html/r80a4dbbb719684c899223a1540e3d608c8fa74928dd9adfe46a5ae06%40%3Cdev.logging.apache.org%3E),
so the above code can either stay as-is or might be changed to use already
available macros `LOG4CXX_PTR_DEF`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
