[ 
https://issues.apache.org/jira/browse/LOG4J2-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296679#comment-17296679
 ] 

Ralph Goers edited comment on LOG4J2-2975 at 3/6/21, 11:47 PM:
---------------------------------------------------------------

I've looked at how SLF4J has added the support for the LogEvent builder. It 
should be possible to implement the support in our 1.8 implementation. It just 
requires overriding 

 
{code:java}
default public LoggingEventBuilder makeLoggingEventBuilder(Level level) {       
    return new DefaultLoggingEventBuilder(this, level);    
}
{code}
in our Logger implementation with something that works better with Log4j2.

 


was (Author: [email protected]):
I've looked at how SLF4J has added the support for the LogEvent builder. It 
should be possible to implement the support in our 1.8 implementation. It just 
requires overriding 

 
{code:java}
default public LoggingEventBuilder makeLoggingEventBuilder(Level level) {       
    return new DefaultLoggingEventBuilder(this, level);    
}
{code}
with in our Logger implementation with something that works better with Log4j2.

 

> SLF4J fluent API fails to capture call site location due to missing 
> LoggingEventAware implementation
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2975
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2975
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: SLF4J Bridge
>    Affects Versions: 2.13.3
>            Reporter: Daniel Gray
>            Priority: Major
>
> The logger outputs the wrong log line (120 for INFO, 117 for DEBUG, etc.) 
> instead of the line in the program that generated the log, when running with 
> the slf4j bridge. *This causes potential confusion when a person debugging 
> something is reading the logs as the line numbers are wrong!*
> I have prepared 2 simple CLI apps to show the correct behavior (with only 
> Log4J) and the incorrect behavior (with the SLF4J bridge). Both are using the 
> exact same configuration (log4j2.properties). The repositories of these 
> sample projects are:
> Good behavior with a pure log4j:
>  [https://github.com/danielthegray/log4j-nobugsample]
>  Wrong behavior with the slf4j bridge:
>  [https://github.com/danielthegray/slf4j-bugsample]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to