rm5248 commented on pull request #60: URL: https://github.com/apache/logging-log4cxx/pull/60#issuecomment-814452988
That is actually a much simpler implementation. I didn't think about doing it that way, as I was thinking about having a fallback method of having a map of thread<->name. That's a potential future optimization for environments that don't have thread_local. Changing the return value of the `Transcoder::decode` may make sense in the future - passing the string to modify into the function looks like an optimization that may no longer be relevant with newer C++ versions, so I would have to do some profiling(which is how I found this in the first place). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
