ams-tschoening commented on a change in pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615268201
##########
File path: CMakeLists.txt
##########
@@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake)
project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CXX)
include(CTest)
+# If you are including log4cxx from a higher-level CMake file(perhaps as a
submodule?)
+# CMAKE_SOURCE_DIR will refer to the first CMakeLists.txt. Since we need some
files
+# in relation to the log4cxx source root, set a variable that contains the
log4cxx root.
+set(LOG4CXX_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
Review comment:
I've simply didn't read correctly, `CMAKE_CURRENT_SOURCE_DIR` vs.
`CMAKE_SOURCE_DIR`, I've read the latter instead of the former. What you say
makes sense of course, no need to change things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
