perry2of5 commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622310736
##########
File path:
log4j-kafka/src/test/java/org/apache/logging/log4j/kafka/builder/ConfigurationBuilderTest.java
##########
@@ -106,14 +112,27 @@ private void addTestFixtures(final String name, final
ConfigurationBuilder<Built
INDENT + "</Loggers>" + EOL +
"</Configuration>" + EOL;
- // TODO make test run properly on Windows
@Test
public void testXmlConstructing() throws Exception {
//assumeTrue(System.lineSeparator().length() == 1); // Only run test
on platforms with single character line endings (such as Linux), not on Windows
Review comment:
Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
