perry2of5 opened a new pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491
This pull fixes the windows build. I have tested on windows 10 using maven 3.6.3 and Zulu's OpenJDK 11 build. It adds an annotation @DisableOnWindows to prevent the FileOutputTest test from running on Windows in log4j-core. This test cannot pass because the listener to the StatusLogger is never shut down. It fixes the XML comparison in ConfigurationBuilderTest in log4j-kafka to compare the XML as documents instead of as Strings which should prevent the OS dependent quirks from causing the test to fail. It also fixes and intermittent nuisance in JsonTemplateLayoutNullEventDelimiterTest which fails when the port is unavailable on windows. I changed the test to catch the exception and print an error rather than fail the build. Ideally we'd find an available dynamically, write out the XML config to a temp file with the targeted port, run the test, and then clean up the temporary config XML file. I took the easy way out here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
