[ 
https://issues.apache.org/jira/browse/LOG4J2-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353708#comment-17353708
 ] 

Volkan Yazici commented on LOG4J2-3089:
---------------------------------------

[~perry2of5], I cannot speak for the rest of the developers, but indeed GitHub 
PRs are more convenient for me. Some remarks:
 * If your changes are small, just like the diff you have shared, you don't 
need to create a JIRA ticket.
 * If your changes are relatively big, has a significant impact regarding the 
way associated component works, or a bug fix, please create a JIRA ticket and 
update {{changes.xml}} in your PR accordingly.
 * If your changes are applicable to both {{release-2.x}} and {{master}} 
branches, I'd appreciate it if you can create two separate PRs targeting both 
branches. This will save me from manually {{cherry-pick}}'ing to the other 
branch and wrestling with potential resolve conflicts along the way.

> JsonTemplateLayoutNullEventDelimiterTest sporadically fails on Windows
> ----------------------------------------------------------------------
>
>                 Key: LOG4J2-3089
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3089
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: JsonTemplateLayout
>    Affects Versions: 2.14.0, 2.14.1
>            Reporter: Tim Perry
>            Assignee: Volkan Yazici
>            Priority: Minor
>             Fix For: 3.0.0, 2.15.0
>
>         Attachments: diff.txt
>
>
> {{JsonTemplateLayoutNullEventDelimiterTest}} sporadically fails in Windows 
> when the port is unavailable. Ideally it would find an available port 
> dynamically, write out the XML config to a temp file with the targeted port, 
> run the test, and then clean up the temporary config XML file. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to