ams-tschoening commented on pull request #67: URL: https://github.com/apache/logging-log4cxx/pull/67#issuecomment-899268642
@rm5248 How about the individual logging statements? Don't they need a semicolon as well? All of those macros have been changed with 0.10.X already: > Regarding the behavior of the LOG4CXX_INFO macro and friends: sorry, but I'm afraid it's impossible to make these macro's behave as ordinary statements without breaking some existing code. Any breakage will be clear however (compiler error) and easy to fix (**by adding a semicolon**). On the other hand, with the current macro's it is possible to create hard to find dangling else problems. https://issues.apache.org/jira/projects/LOGCXX/issues/LOGCXX-319 This PR might be a good chance to change all of these lines as well: > LOG4CXX_INFO(logger, "Entering application.") vs. > LOG4CXX_INFO(logger, "Entering application."); -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
