edwgiz commented on pull request #2: URL: https://github.com/apache/logging-log4j-tools/pull/2#issuecomment-947153607
Thanks for positive feedback Without MANIFEST.MF the build fails [ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.2.0:jar (default-jar) on project log4j-maven-plugins-shade-transformer: Error assembling JAR: Manifest file: logging-log4j-tools/log4j-maven-plugins/log4j-maven-plugins-shade-transformer/target/classes/META-INF/MANIFEST.MF does not exist If you have any idea how to gracefully deal with the error I will appreciate it -- Best regards, Ed On Tue, Oct 19, 2021 at 11:29 PM Volkan Yazıcı ***@***.***> wrote: > Fantastic work @edwgiz <https://github.com/edwgiz>, thanks so much! > > One more question: I am a MANIFEST.MF noob, is the empty file necessary? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j-tools/pull/2#issuecomment-947080992>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AOPG2RJ2YXHRKTCEY6SPP4TUHXILPANCNFSM5GIL5BUA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
