rm5248 commented on pull request #73: URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947277364
> It is a benchmarking thing. Your benchmarking tools look good. When are you thinking you will merge? I don't have any timeframe for that at the moment. It is mostly so that I can find areas for improvement at the moment. There has been some talk on the development list about continuous performance testing for log4j2, so it would be nice to be able to piggyback off of that at some point. > Have you run the benchmarks without the std::mutex lock in Hierarchy::isDisabled()? (I do not think that lock is necessary as it is only a read) I have not. My concern with changing things like that is that we don't have great tests at the moment that test various multithreaded configurations(LOGCXX-534 [comes to mind](https://github.com/apache/logging-log4cxx/commit/a0a24987fd28b2bcd2a2628c949b01745851c634)). If you want to discuss more on the performance aspects, that's probably better discussed on the mailing list. I'm working on some long-term issues at the moment, and performance is something that I'm looking to improve, if you're looking to help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
