vy commented on pull request #591: URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950371887
> Are we losing any code coverage due to the removal of tests? Not as far as I can see. The following tests were removed: `SocketMessageLossTest`, `SocketReconnectTest`, and `SocketTest`. Except `SocketReconnectTest`, the other two were already disabled. The new `SocketAppenderReconnectTest` added covers exactly the two cases covered in `SocketReconnectTest` and performs a more elaborate check due to the corner cases subject to this PR, i.e., [LOG4J2-2829](https://issues.apache.org/jira/browse/LOG4J2-2829). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
