fluffynuts commented on a change in pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65#discussion_r735437906



##########
File path: src/log4net/Appender/RollingFileAppender.cs
##########
@@ -1158,10 +1158,8 @@ override public void ActivateOptions()
                                m_baseFileName = base.File;
                        }
 
-#if !NETCF
                        // initialize the mutex that is used to lock rolling
-                       m_mutexForRolling = new Mutex(false, 
m_baseFileName.Replace("\\", "_").Replace(":", "_").Replace("/", "_"));
-#endif
+                       m_mutexForRolling = new 
FileBasedMutex($"{m_baseFileName}.lock");

Review comment:
       Please find a way to make this change specific to the platforms that 
need it - I don't want to risk issues on platforms where this is not a problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to