RyanShin0112 opened a new pull request #74: URL: https://github.com/apache/logging-log4cxx/pull/74
There are two error handlers in log4cxx(OnlyOnceErrorHandler and FallbackErrorHandler) but only ‘OnlyOnceErrorHandler’ gets registered. The reason is that ‘FallbackErrorHandler’ is not referenced anywhere, so IMPLEMENT_LOG4CXX_OBJECT() for ‘FallbackErrorHandler’ won’t get called. On the other hand, ‘OnlyOnceErrorHandler’ is referenced from appenderskeleton.cpp so class registration for that class will be done without any problem. For the classes that are not internally referenced, Log4cxx is designed to register the classes in ‘Class::registerClasses()’, but ‘FallbackErrorHandler’ seems to be missing. Since 'FallbackErrorHandler' is a built-in handler, I think the library should register that class by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
