garydgregory commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-963104008
> Actually, the problems with the ErrorHandler are much bigger than this. See https://issues.apache.org/jira/browse/LOG4J2-2927. This issue should also have a Jira as it is a separate problem but users really should be able to add their own ErrorHandler. It is just a matter of make it a Plugin. Ralph > […](#) > On Nov 7, 2021, at 9:57 AM, Gary Gregory ***@***.***> wrote: I am not sure this solves the whole issue of multi-threading usage, in particular, I wonder if the methods that access both of these variables shouldn't just be synchronized instead. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <[#596 (comment)](https://github.com/apache/logging-log4j2/pull/596#issuecomment-962645063)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA5MXZM62XET73R3IQKFK3UK2VYVANCNFSM5HQU6P3Q>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. It sounds like we have two separate issues: - A feature request: As a user, I want to configure my error handler from a configuration file, so make the handler a plugin. That's [LOG4J2-2927] - A bug: The instance variables in the default error handler may be updated in the same methods from different threads. Making the methods that access these variables synchronized is the simple solution. The user will be left to deal with their own bugs in their custom or third-party error handlers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
