ams-tschoening edited a comment on pull request #75: URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-979241416
Thanks for adding this and having that option seems fine to me. Though: I don't like the current wording about file name vs. short file name vs. actually being some file path. Files even sort badly right now. Do we have any chance to rename things to what they really are most likely? A file path, a file name, a method name etc. This might result in `FilePathLocation...` and `FileNameLocation...`. More descriptive pattern characters might even be introduced like `fn` and `fp` for file name and file path. The only problem I see right now is with `getFileName` being already available and possibly returning a path instead of a file name only in the past. This would be a breaking change for people relying on a path being available. Though, with some different pair of getters like `getFname` and `getFpath` this method might be kept and deprecated or alike. Opinions, does anyone think it's worth it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
