carterkozak commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-982491749


   > I am unclear as to why a system property was needed if only Pattern Layout 
is affected.
   
   We had hundreds of services, each of which with default configurations and 
per-install overrides, where developers copied patterns from other services 
(some of which using logj1.2) -- the property was helpful because I was able to 
set it in a shared log4j2.component.properties and apply the behavior 
everywhere.
   
   > I would suggest simply reversing this so that lookups are disabled by 
default and adding a "lookups" option will enable them.
   
   I had considered this and decided it may cause more friction for consumers 
who want to revert the behavior, but I agree with you that the end result is 
much more desirable. I'll remove the property and take this approach :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to