rm5248 commented on pull request #81:
URL: https://github.com/apache/logging-log4cxx/pull/81#issuecomment-991664058


   I was actually just about to go and fix this by creating a new file that was 
in Windows(CRLF) line endings, since that particular property is only used in 
[one 
test.](https://github.com/apache/logging-log4cxx/blob/d08a933041c87c7a68908334df5b0cceadd3a7f5/src/test/cpp/helpers/propertiestestcase.cpp#L158)
  Is there some reason we want to have a file with mixed line endings?  Keeping 
it separate seems like the best idea to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to