carterkozak commented on a change in pull request #623:
URL: https://github.com/apache/logging-log4j2/pull/623#discussion_r767392960
##########
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/MessagePatternConverterTest.java
##########
@@ -121,7 +121,7 @@ public void testLookup() {
.setMessage(msg).build();
final StringBuilder sb = new StringBuilder();
converter.format(event, sb);
- assertEquals("bar", sb.toString(), "Unexpected result");
+ assertEquals("${foo}", sb.toString(), "Unexpected result");
Review comment:
Given the feature is gone, we can probably remove this test as it’s
covered elsewhere
##########
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/PatternLayoutLookupDateTest.java
##########
@@ -38,7 +38,7 @@ public void testDateLookupInMessage(final LoggerContext
context, @Named("List")
final String template = "${date:YYYY-MM-dd}";
context.getLogger(PatternLayoutLookupDateTest.class.getName()).info(template);
final String string = listAppender.getMessages().get(0);
- assertFalse(string.contains(template), string);
+ assertTrue(string.contains(template), string);
Review comment:
This class and log4j-list-lookups.xml could be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
