[
https://issues.apache.org/jira/browse/LOG4J2-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465046#comment-17465046
]
Volkan Yazici commented on LOG4J2-3286:
---------------------------------------
_"Isn't catching Throwable considered a bad practice?"_ I think, it certainly
is. If you have a better idea for the problem described in LOG4J2-2972, please
share.
> 2.17 has reverted LOG4J-2972 fix in AppenderControl but change not in history
> -----------------------------------------------------------------------------
>
> Key: LOG4J2-3286
> URL: https://issues.apache.org/jira/browse/LOG4J2-3286
> Project: Log4j 2
> Issue Type: Question
> Components: Appenders
> Affects Versions: 2.17.0
> Environment: Windows desktop running unit tests with log4j 2.17
> Reporter: Ben Thurley
> Priority: Major
>
> Upgrading to 2.17 to fix the slew of vulnerabilities has resulted in a change
> to error handling in the logs.
> Specifically in the class:
> org.apache.logging.log4j.core.config.AppenderControl
> There is a method called tryCallAppender() which as of 2.14.1 had been set to
> catch Exception. Looking at the history I can see no further changes to
> revert this to handling Throwable, however, comparing the source for 2.16.
> and 2.17 this is exactly what has changed.
> I don't believe this change should have reverted and if it should then why
> isn't there a commit for it in the history?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
