srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775126323
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##########
@@ -168,6 +168,11 @@
private static final int BUF_SIZE = 256;
+ /**
+ * The maximum number of recursions performed during substitution.
+ */
+ private static final int MAX_SUBSTITUTION_RECURSIONS = 10;
Review comment:
The reason I didn't put this in a property is that I don't think people
are likely to need to adjust this. A configuration that needs more than 10
recursions to get to the final value is going to be hard to reason about, and
is probably not a good idea even if log4j can technically do it. If you think
10 is too conservative, I'm happy to bump it up to something else.
If you feel strongly that this property is something people will need to
adjust I'm also happy to add (and document) a system property for it, I just
think it is a waste to do so unless you think people are going to need to
modify the limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
