swebb2066 commented on pull request #96: URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1005192530
To prevent unnecessary locks in #90 it was necessary to change the return type of getEffectiveLevel() to a const reference. So RVO probably does not happen for virtual functions. It surprised me - I only found it by using perf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
