garydgregory commented on pull request #680:
URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1007372996


   Hi @benjaminr-ps 
   
   Thank you for your PR. Would you add a test please? 
   
   Without a test there is no way to see that this fixes anything or that the 
undoing the fix would break anything (a regression).
   
   See PropertiesConfigurationTest for an example.
   TY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to