garydgregory commented on a change in pull request #717:
URL: https://github.com/apache/logging-log4j2/pull/717#discussion_r786715672
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThreadContextDataInjector.java
##########
@@ -62,21 +62,9 @@
public static Collection<ContextDataProvider> contextDataProviders =
new ConcurrentLinkedDeque<>();
- private static volatile List<ContextDataProvider> serviceProviders = null;
- private static final Lock providerLock = new ReentrantLock();
+ private static final List<ContextDataProvider> serviceProviders =
getServiceProviders();
Review comment:
Our static finals (constants) should be in upper-case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
