[ 
https://issues.apache.org/jira/browse/LOG4J2-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479224#comment-17479224
 ] 

Volkan Yazici commented on LOG4J2-3303:
---------------------------------------

[~ramananravi], that is indeed a good question and [~rgoers] was on spot. In 
particular, I have started my work by applying your changes and moved over it. 
I have experimented a lot with {{Math.multiplyExact()}} and {{BigDecimal}} 
along the way, though I have thrown all of 'em out. I have also removed a 
redundant test, etc. Long story short, I have dirtied my local copy enough that 
I wanted to merge all changes in once, which makes it easier to track changes 
associated with a ticket.

The bottom line is, your PR was in perfect shape, keep those coming! (y)

> Add support for FileSize in TB
> ------------------------------
>
>                 Key: LOG4J2-3303
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3303
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Ramanan Ravi
>            Assignee: Volkan Yazici
>            Priority: Minor
>             Fix For: 2.17.2
>
>
> Currently the default value of 'exceeds' attribute of 'IfAccumulatedFileSize' 
> is Long.MAX_VALUE, which is considerably larger than 1000 TB itself. Hence 
> adding support for specifying 'exceeds' parameter in TB (TeraBytes) would be 
> relevant.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to