kennymacleod commented on a change in pull request #761:
URL: https://github.com/apache/logging-log4j2/pull/761#discussion_r809919901



##########
File path: 
log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java
##########
@@ -125,6 +125,15 @@ public void testConsoleAppenderLevelRangeFilter() throws 
Exception {
       }
     }
 
+    @Test
+    public void testConfigureAppenderDoesNotExist() throws Exception {
+        // Verify that we tolerate a logger which specifies an appender that 
does not exist.
+        try (LoggerContext loggerContext = 
TestConfigurator.configure("target/test-classes/LOG4J2-3407.properties")) {
+            final Configuration configuration = 
loggerContext.getConfiguration();
+            assertNotNull(configuration);
+        }

Review comment:
       This test fails with an NPE without the fix




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to