ppkarwasz commented on pull request #753: URL: https://github.com/apache/logging-log4j2/pull/753#issuecomment-1045968986
Regarding the inclusion in version 2.17.2 (cf. [this thread](https://lists.apache.org/thread/fk538mcvyf6n8wsbxpfjrlnj9kk71hj8)), the two commented snippets of code are easy to verify and a must have. The rest of the PR is only a performance optimization: in the worst case scenario of n chained legacy filters (each returning `NEUTRAL`), O(n^2) filters are executed per log message. In the more common scenario of n native Log4j 2.x filters, only n filters are evaluated (they "lose" the chain when the `AppenderWrapper` is unwrapped). In any case the evaluation of the filters gives always the correct result. If a deadline is approaching, I wouldn't rush to include the whole PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
