garydgregory commented on a change in pull request #764:
URL: https://github.com/apache/logging-log4j2/pull/764#discussion_r810672064
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationParser.java
##########
@@ -103,6 +107,18 @@
if (Boolean.parseBoolean(debugValue)) {
builder.setStatusLevel(Level.DEBUG);
}
+ // if log4j.reset=true then reset hierarchy
+ final String reset = getLog4jValue("reset");
+ if (reset != null && OptionConverter.toBoolean(reset, false)) {
Review comment:
I do not see this reset setting tested in this PR. Did I miss it? Also,
elsewhere we call the reset API from a doConfigure() method, it seems odd to
call it here. Is it then called twice or should this call be moved to the site
when the configuration is actually applied? @rgoers WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
