garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r820722891
##########
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##########
@@ -30,4 +40,29 @@ public void testJira_LOG4J2_2770_byteArray() throws
Exception {
ConfigurationSource configurationSource = new ConfigurationSource(new
ByteArrayInputStream(new byte[] { 'a', 'b' }));
assertNotNull(configurationSource.resetInputStream());
}
+
+ /**
+ * Checks if the usage of 'jar:' URLs does not increase the file descriptor
+ * count. Does not work on Windows, since the is no way to count open
+ * descriptors.
+ *
Review comment:
Hi @ppkarwasz
Can't this be tested everywhere by simply trying to copy or delete the jar
file? That's the real-life use case IIRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
