ppkarwasz commented on a change in pull request #789:
URL: https://github.com/apache/logging-log4j2/pull/789#discussion_r825309484
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/xml/XmlConfiguration.java
##########
@@ -675,24 +675,13 @@ private void parseLevel(Element element, LoggerConfig
logger, boolean isRoot) {
}
} else {
String className = subst(element.getAttribute(CLASS_ATTR));
+ final Level level;
if (EMPTY_STR.equals(className)) {
- logger.setLevel(OptionConverter.convertLevel(priStr,
org.apache.logging.log4j.Level.DEBUG));
+ level = OptionConverter.toLevel(priStr, Level.DEBUG);
Review comment:
I'll look into that. There are actually two levels used throughout the
code: `Level.DEBUG` in places where we expect an operation to fail and
`Level.ERROR` where a conversion failure is unexpected (like in the
`convertLevel` methods).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
