garydgregory commented on code in PR #815:
URL: https://github.com/apache/logging-log4j2/pull/815#discussion_r845557940
##########
log4j-api/src/main/java/org/apache/logging/log4j/Level.java:
##########
@@ -259,15 +258,23 @@ public String toString() {
* @throws java.lang.IllegalArgumentException if the name is null or
intValue is less than zero.
*/
public static Level forName(final String name, final int intValue) {
- final Level level = LEVELS.get(name);
Review Comment:
Above we use Strings.isEmpty(name), shouldn't we use the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]