remkop commented on code in PR #824:
URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852916502
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigDisruptor.java:
##########
@@ -166,10 +166,13 @@ private void notifyIntermediateProgress(final long
sequence) {
private EventFactory<Log4jEventWrapper> factory;
private EventTranslatorTwoArg<Log4jEventWrapper, LogEvent,
AsyncLoggerConfig> translator;
private volatile boolean alreadyLoggedWarning;
+ private final AsyncWaitStrategyFactory asyncWaitStrategyFactory;
+ WaitStrategy waitStrategy; // package-protected for testing
Review Comment:
Makes sense. Done.
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerDisruptor.java:
##########
@@ -51,14 +53,17 @@ class AsyncLoggerDisruptor extends AbstractLifeCycle {
private volatile Disruptor<RingBufferLogEvent> disruptor;
private String contextName;
+ private final Supplier<AsyncWaitStrategyFactory>
waitStrategyFactorySupplier;
private boolean useThreadLocalTranslator = true;
private long backgroundThreadId;
private AsyncQueueFullPolicy asyncQueueFullPolicy;
private int ringBufferSize;
+ WaitStrategy waitStrategy; // package-protected for testing
Review Comment:
Makes sense. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
