[ https://issues.apache.org/jira/browse/LOG4J2-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543308#comment-17543308 ]
ASF subversion and git services commented on LOG4J2-3520: --------------------------------------------------------- Commit 68097f8e29fa91ff5cb9fcf09dddf7d6b0c0cca5 in logging-log4j2's branch refs/heads/dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.2.0 from Michael Ernst [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=68097f8e29 ] LOG4J2-3520 Update outdated Maven Toolchains instructions. (#894) > sample toolchains.xml files do not provide JDK 11 > ------------------------------------------------- > > Key: LOG4J2-3520 > URL: https://issues.apache.org/jira/browse/LOG4J2-3520 > Project: Log4j 2 > Issue Type: Documentation > Components: Documentation > Affects Versions: 2.17.2 > Reporter: Michael Ernst > Assignee: Volkan Yazici > Priority: Minor > Fix For: 2.18.0 > > > File `BUILDING.md` says to use one of these command-line arguments: > {quote} > [Macintosh] -t ./toolchains-sample-mac.xml > [Windows] -t ./toolchains-sample-win.xml > [Linux] -t ./toolchains-sample-linux.xml > {quote} > But those files are inconsistent with file > `.github/workflows/maven-toolchains.xml`. > I suggest that all these files be made consistent with one another. > (It looks to me like `.github/workflows/maven-toolchains.xml` is probably the > right one to copy from.) > Alternately, a way to prevent such mismatches in the future is to delete the > 3 "sample" toolchain files and change the instructions to say to set two > environment variables (for example > {quote} > export JAVA_HOME_8_X64=$HOME/java/jdk8 > export JAVA_HOME_11_X64=$HOME/java/jdk11 > {quote} > ) and then use > {quote} > --global-toolchains ".github/workflows/maven-toolchains.xml" > {quote} -- This message was sent by Atlassian Jira (v8.20.7#820007)